This week I reviewed my notes about code review and noticed there’s something I haven’t written about: code review often happens too late. Typically a developer requests code review for their pull request once it’s pretty much done. This is too late. If you have developed a big change and the reviewer thinks the whole approach is wrong, it’s wasteful to throw the whole change away at this point, and it’s not fun feedback to get. This puts a limit on how big changes the reviewer can ...
