A code review that doesn’t go right. (image by Manu Cornet, CC BY-NC-ND 3.0) I’ve reviewed over 3000 code changes so far in my career, and gone through about same amount of reviews as change author. When reviewing code, here is the golden rule I follow: Any code change that’s a strict improvement should be approved. Most incoming code reviews are both improvements in some aspects and make things worse in other aspects. Understand the change It’s tempting to glance over a change and on...
